feat: add parallel bandwidth measurements - #154
Draft
andre-j3sus wants to merge 1 commit into
Draft
Conversation
|
LGTM! |
andre-j3sus
commented
Aug 28, 2026
| | **autoStart**: *boolean* | Whether to automatically start the measurements on instantiation. | `true` | | ||
| | **downloadApiUrl**: *string* | The URL of the API for performing download GET requests. | `https://speed.cloudflare.com/__down` | | ||
| | **uploadApiUrl**: *string* | The URL of the API for performing upload POST requests. | `https://speed.cloudflare.com/__up` | | ||
| | **bandwidthOrigins**: *string[]* | Origins used for bandwidth requests. The engine appends `/__down` or `/__up` and distributes parallel requests across the origins. When omitted, `downloadApiUrl` and `uploadApiUrl` are used. | `[]` | |
Collaborator
Author
There was a problem hiding this comment.
API design question: The current API uses complete endpoint URLs:
downloadApiUrl: "https://speed.cloudflare.com/__down"
uploadApiUrl: "https://speed.cloudflare.com/__up"This proposal adds bandwidthOrigins and derives /__down and /__up automatically:
bandwidthOrigins: ["https://speed-0.example.com"]To remain consistent with the existing full-URL approach, alternatives would be paired endpoints:
bandwidthEndpoints: [{ download: ".../__down", upload: ".../__up" }]or separate downloadApiUrls and uploadApiUrls arrays. Reviewers, which contract do you prefer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds configurable bandwidth origins and numeric parallelism at both the test and individual-step levels. Bandwidth requests run in bounded batches, with aggregate bytes and throughput calculated across each overlapping transfer window and reported through the existing results payload.
Sequential execution remains the default, while physical-request logging stays per request and final session metadata records the expected maximum parallelism.